Skip to content

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jun 27, 2018

fixes #51841

r? @Zoxc

@oli-obk oli-obk added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 27, 2018
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 27, 2018
@Zoxc
Copy link
Contributor

Zoxc commented Jun 27, 2018

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 27, 2018

📌 Commit 89d8e0a has been approved by Zoxc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2018
@pietroalbini
Copy link
Member

@bors p=1 (beta nominated, fixes a regression)

@bors
Copy link
Collaborator

bors commented Jun 27, 2018

⌛ Testing commit 89d8e0a with merge 23b5516...

bors added a commit that referenced this pull request Jun 27, 2018
Don't use `ParamEnv::reveal_all()` if there is a real one available

fixes #51841

r? @Zoxc
@bors
Copy link
Collaborator

bors commented Jun 27, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Zoxc
Pushing 23b5516 to master...

@bors bors merged commit 89d8e0a into rust-lang:master Jun 27, 2018
@pietroalbini pietroalbini added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 27, 2018
@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jun 28, 2018
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 28, 2018
bors added a commit that referenced this pull request Jun 28, 2018
[beta] Rollup backports

Merged and approved:

* #51725: Do not build LLVM tools for any of the tools
* #51852: Don't use `ParamEnv::reveal_all()` if there is a real one available
* #51686: yet another "old borrowck" bug around match default bindings
* #51868: Remove process::id from 'Stabilized APIs' in 1.27.0 release notes
*  #51335: Prohibit `global_allocator` in submodules

r? @ghost
@oli-obk oli-obk deleted the miri_fix branch June 15, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE while compiling the ffi_helpers in 1.28 beta
6 participants